AP_HAL_ChibiOS: Fix waf --default-parameters #13512
Conversation
If a defaults.parm file was present in the hwdef, waf ignored the --default-parameters=xyz.parm command line argument. This will allow it to use that command line argument specified file.
|
I'm wondering if it might be a good idea to append the |
|
@Pedals2Paddles that would have been my assumption for how that would work actually, but I could see the debate either way. |
|
On second thought, I'm not sure I want to do that. The user specified a set of params. I can't make a new combined file, because now it's something else the user doesn't even have. And I can't append or prepend without totally hosing the users files. So I think it needs to just be the users file or not. |
|
I've been using this all weekend with no defaults, hwdef defaults, and command line specified defaults. It's working splendid. |
|
nice work, thanks! |
|
Sorry I missed this on the dev call. Thanks Tridge! |
|
this is included in Copter-4.0.4-rc1 |
|
Sorry to comment on such an old post, but I am having trouble getting default params flashed to my board. I've tried both a Pixhawk 4 and a mRoControlZero. I've tried various different commands/approaches without success. Here's what I think I should be running: During the build, I see it says "Setting defaults from /home/ubuntu/ardupilot_params/defaults.parm" so it appears the command is working, however, the params on the autopilot do not reflect what are stored in my file. I've tried comma-separated, space-separated, even adding param defaults to the "hwdef/mRoControlZeroOEMH7/defaults.parm" file. Most of my testing has been on the latest version of ardupilot, but I also checked out this commit (e6f32f4) with no success. Am I missing something? Thanks. |
If a defaults.parm file was present in the hwdef, waf configure ignored the
--default-parameterscommand line argument. It also treated any specified file as it's root being the repo directory, which is not very useful. It would turn an absolute path into something ridiculous like/home/matt/github/ardupilot/home/matt/Desktop/paramfile.paramswhich is clearly invalid.This PR does a few things to fix all this.
./waf configure CubeOrange --default-parameters=/home/matt/Desktop/paramfile.params.--default-parametersargument will take precedent over adefaults.parmfile in the hwdef directory.It should be noted, which I didn't know until this, that this command line argument is only used in configure. Not in the build command.